Skip to content

Conversation

@nefelimet
Copy link
Collaborator

No description provided.

@nefelimet nefelimet changed the title Add functionality for geometry swapping from DXF file FEAT: Add functionality for geometry swapping from DXF file Sep 16, 2025
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a test. Extensions are also tested

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.89%. Comparing base (43644a7) to head (ffc5e2c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1529      +/-   ##
==========================================
+ Coverage   70.86%   70.89%   +0.02%     
==========================================
  Files         225      226       +1     
  Lines       40630    40670      +40     
==========================================
+ Hits        28794    28834      +40     
  Misses      11836    11836              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the testing Anything related to testing label Sep 23, 2025
svandenb-dev
svandenb-dev previously approved these changes Sep 24, 2025
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added maintenance Package and maintenance related dependencies Related with project dependencies labels Oct 23, 2025
svandenb-dev
svandenb-dev previously approved these changes Oct 23, 2025
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev enabled auto-merge (squash) October 23, 2025 14:44
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev self-requested a review October 28, 2025 10:10
svandenb-dev
svandenb-dev previously approved these changes Oct 28, 2025
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svandenb-dev svandenb-dev merged commit d0860b7 into main Oct 28, 2025
27 of 28 checks passed
@svandenb-dev svandenb-dev deleted the geom_swap_ext branch October 28, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related with project dependencies maintenance Package and maintenance related testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants